Skip to content

Fix binary check in binary dumper #18241

Closed
@geek-merlin

Description

@geek-merlin

In #17863 a binary check is introduced like
preg_match('/[^\x09-\x0d\x20-\xff]/', $value)

This is not specific, in the sense that some invalid utf8 won't be recognized as binary.

The recognition is nontrivial iterating a byte sequence, but PHP has some simple one-liners to do it like
$isUTF8 = preg_match('//u', $string);

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions