Skip to content

[Routing] build query string with PHP_QUERY_RFC3986 #19625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatTheCat opened this issue Aug 16, 2016 · 1 comment
Closed

[Routing] build query string with PHP_QUERY_RFC3986 #19625

MatTheCat opened this issue Aug 16, 2016 · 1 comment

Comments

@MatTheCat
Copy link
Contributor

MatTheCat commented Aug 16, 2016 •
edited
Loading

UrlGenerator doesn't use http_build_query fourth parameter, thus encoding spaces as + because of the application/x-www-form-urlencoded media type.

As route extra parameters aren't used in a form context I think PHP_QUERY_RFC3986 should be used.

Twig does that already.
@Tobion
Copy link
Contributor

Tobion commented Aug 16, 2016

👍

This was referenced Aug 16, 2016
Closed
Closed
fabpot added a commit that referenced this issue Aug 18, 2016
@fabpot
feature #19639 [Routing] Generate URLs in compliance with PHP_QUERY_R…
885c388 
…FC3986 (jameshalsall)

This PR was submitted for the 2.7 branch but it was merged into the 3.2-dev branch instead (closes #19639).

Discussion
----------

[Routing] Generate URLs in compliance with PHP_QUERY_RFC3986

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no?
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19625
| License       | MIT
| Doc PR        |

Commits
-------

ce724e2 [Routing] Generate URLs in compliance with PHP_QUERY_RFC3986
@fabpot fabpot closed this as completed Aug 18, 2016
@likeuntomurphy likeuntomurphy mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @Tobion @MatTheCat