Skip to content

Fixing PHP's #72972 make tests fail #19885

Closed
@jpauli

Description

@jpauli

Hi.

I fixed https://bugs.php.net/bug.php?id=72972
Merged against next releases for stable active branches.

This introduces 4 test fails in IpValidatorTest.
There were 4 failures:

  1. Symfony\Component\Validator\Tests\Constraints\IpValidatorTest::testInvalidReservedIpsV4 with data set Untitled #1 ('224.0.0.1')
    1 violation(s) expected. Got 0.
    Failed asserting that 0 is identical to 1.

/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:314
/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php:211

  1. Symfony\Component\Validator\Tests\Constraints\IpValidatorTest::testInvalidPublicIpsV4 with data set Same change for mapping files #4 ('224.0.0.1')
    1 violation(s) expected. Got 0.
    Failed asserting that 0 is identical to 1.

/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:314
/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php:238

  1. Symfony\Component\Validator\Tests\Constraints\IpValidatorTest::testInvalidReservedIpsAll with data set Untitled #1 ('224.0.0.1')
    1 violation(s) expected. Got 0.
    Failed asserting that 0 is identical to 1.

/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:314
/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php:420

  1. Symfony\Component\Validator\Tests\Constraints\IpValidatorTest::testInvalidPublicIpsAll with data set Same change for mapping files #4 ('224.0.0.1')
    1 violation(s) expected. Got 0.
    Failed asserting that 0 is identical to 1.

/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/AbstractConstraintValidatorTest.php:314
/home/jpauli/www/symfony/Symfony/src/Symfony/Component/Validator/Tests/Constraints/IpValidatorTest.php:443

Please, review php/php-src@5f5f62c for changes and https://tools.ietf.org/html/rfc6890 for why those changes.

Thx.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions