Skip to content

TranslationUpdateCommand test failure on master #19921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolas-grekas opened this issue Sep 12, 2016 · 6 comments
Closed

TranslationUpdateCommand test failure on master #19921

nicolas-grekas opened this issue Sep 12, 2016 · 6 comments

Comments

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 12, 2016

If someone wants to have a look, it'd be great!
https://travis-ci.org/symfony/symfony/builds/159397742

@jakzal
Copy link
Contributor

jakzal commented Sep 13, 2016

@nicolas-grekas I can no longer run tests locally. Am I missing something? Running the phpunit wrapper just outputs the first line:

image

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Sep 13, 2016

composer update first, then try again? maybe remove the .phpunit folder before?

@jakzal
Copy link
Contributor

jakzal commented Sep 13, 2016

Ok, I figured it out.

This works:

./phpunit src/Symfony/Bundle/FrameworkBundle/

and this doesn't:

./phpunit src/Symfony/Bundle/FrameworkBundle/Tests

@nicolas-grekas
Copy link
Member Author

Did it work previously?

@jakzal
Copy link
Contributor

jakzal commented Sep 13, 2016

re #19325 #19878

@jakzal
Copy link
Contributor

jakzal commented Sep 13, 2016

Did it work previously?

Not sure to be honest, but it definitely works with phpunit directly.

nicolas-grekas added a commit that referenced this issue Sep 13, 2016
…as-grekas)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[Bridge/PhpUnit] Fix running subparts of components

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| Tests pass?   | yes
| License       | MIT

As spotted by @jakzal in #19921 (comment)

Diff best viewed ignoring white spaces: https://github.com/symfony/symfony/pull/19927/files?w=1

Commits
-------

37e6c1c [Bridge/PhpUnit] Fix running subparts of components
nicolas-grekas added a commit that referenced this issue Sep 13, 2016
… a merge (jakzal)

This PR was merged into the 3.2-dev branch.

Discussion
----------

[FrameworkBundle] Fix TranslationUpdateCommand tests after a merge

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #19921
| License       | MIT
| Doc PR        | -

#19325 relied on a wrong count of messages, which was fixed by #19878.
Additionally, the `getContainer()` method on the master branch expect messages to be indexed by domain.

Commits
-------

d093c40 [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants