-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
TranslationUpdateCommand test failure on master #19921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@nicolas-grekas I can no longer run tests locally. Am I missing something? Running the phpunit wrapper just outputs the first line: |
|
Ok, I figured it out. This works:
and this doesn't:
|
Did it work previously? |
Not sure to be honest, but it definitely works with phpunit directly. |
nicolas-grekas
added a commit
that referenced
this issue
Sep 13, 2016
…as-grekas) This PR was merged into the 3.2-dev branch. Discussion ---------- [Bridge/PhpUnit] Fix running subparts of components | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | Tests pass? | yes | License | MIT As spotted by @jakzal in #19921 (comment) Diff best viewed ignoring white spaces: https://github.com/symfony/symfony/pull/19927/files?w=1 Commits ------- 37e6c1c [Bridge/PhpUnit] Fix running subparts of components
nicolas-grekas
added a commit
that referenced
this issue
Sep 13, 2016
… a merge (jakzal) This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19921 | License | MIT | Doc PR | - #19325 relied on a wrong count of messages, which was fixed by #19878. Additionally, the `getContainer()` method on the master branch expect messages to be indexed by domain. Commits ------- d093c40 [FrameworkBundle] Fix TranslationUpdateCommand tests after a merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If someone wants to have a look, it'd be great!
https://travis-ci.org/symfony/symfony/builds/159397742
The text was updated successfully, but these errors were encountered: