[Translation] not including fallback locales in cache meta files #20420

msheakoski · 2016-11-05T23:54:27Z

When using the Translation component in debug mode, I noticed that the .meta files being generated do not include references to fallback locale files, even though the actual cache file contains messages from the fallback locales. This is an issue because any changes made to one of the fallback locale files will not take effect unless the cache is deleted.

Interestingly, in the example, when instantiating the translator with the locale of "fr" instead of "fr_FR", the .meta file correctly contains references to the main locale and fallback locales.

example.php:

<?php declare(strict_types = 1);

use Symfony\Component\Translation\Translator;
use Symfony\Component\Translation\Loader\PhpFileLoader;

// require symfony/translation and symfony/config in composer.json
require "vendor/autoload.php";

$path = pathinfo(__FILE__);
$frResourceFile = "{$path["filename"]}.trans.fr.php";
$enResourceFile = "{$path["filename"]}.trans.en.php";

file_put_contents($frResourceFile, '<?php return ["greeting" => "Salut!"];');
file_put_contents($enResourceFile, '<?php return ["greeting" => "Hello!"];');

$trans = new Translator("fr_FR", null, ".", true);
$trans->setFallbackLocales(["en"]);
$trans->addLoader("php", new PhpFileLoader());
$trans->addResource("php", $frResourceFile, "fr");
$trans->addResource("php", $enResourceFile, "en");

echo $trans->trans("greeting");

Expected catalogue.fr.xxxxx.php.meta to contain:

a:2:{i:0;C:46:"Symfony\Component\Config\Resource\FileResource":76:{s:68:
"/path/to/example.trans.fr.php"
;}i:1;C:46:"Symfony\Component\Config\Resource\FileResource":76:{s:68:
"/path/to/example.trans.en.php";}}

But instead received:

a:1:{i:0;C:46:"Symfony\Component\Config\Resource\FileResource":76:{s:68:
"/path/to/example.trans.fr.php";}}

As a temporary workaround for anyone else having this issue, you can pass null to the third parameter while developing and it won't create cache files, avoiding the issue:

$debug = (getenv("DEBUG_MODE") === "true");
$cacheDir = $debug ? null : "/path/to/cache";
$trans = new Translator("fr_FR", null, $cacheDir, $debug);

aitboudad · 2016-11-06T09:10:30Z

see #20422

…talogues. (aitboudad) This PR was merged into the 2.7 branch. Discussion ---------- [Translation][fallback] add missing resources in parent catalogues. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20420 | License | MIT | Doc PR | ~ Commits ------- 27c91e5 [Translation][fallback] add missing resources in parent catalogues.

msheakoski changed the title ~~Translation component not including fallback locales in cache meta files~~ [Translation] not including fallback locales in cache meta files Nov 6, 2016

aitboudad mentioned this issue Nov 6, 2016

[Translation][fallback] add missing resources in parent catalogues. #20422

Merged

javiereguiluz added Bug Translation labels Nov 6, 2016

carsonbot added the Status: Needs Review label Nov 6, 2016

fabpot closed this as completed Nov 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Translation] not including fallback locales in cache meta files #20420

[Translation] not including fallback locales in cache meta files #20420

msheakoski commented Nov 5, 2016 •

edited by javiereguiluz

Loading

aitboudad commented Nov 6, 2016

[Translation] not including fallback locales in cache meta files #20420

[Translation] not including fallback locales in cache meta files #20420

Comments

msheakoski commented Nov 5, 2016 • edited by javiereguiluz Loading

aitboudad commented Nov 6, 2016

msheakoski commented Nov 5, 2016 •

edited by javiereguiluz

Loading