Skip to content

[TwigBundle] Non-existing method call #20435

Closed
@FrancescoBorzi

Description

@FrancescoBorzi

In: https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/TwigBundle/Controller/ExceptionController.php#L137

there is this line:

$loader->getSource($template);

both my IDE and phpunit complain that the method getSource() does not exist, which is causing me troubles when writing unit tests.

Also I don't understand the purpose of that call, it is a get method so it is supposed to return something, but we are never using the returned value.

I guess lines 136-141 can just be removed, in that case I can open a PR.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions