Skip to content

Profiler router panel errors when no route params present #20650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gedimin45 opened this issue Nov 27, 2016 · 2 comments
Closed

Profiler router panel errors when no route params present #20650

gedimin45 opened this issue Nov 27, 2016 · 2 comments
Labels
Status: Reviewed

Comments

@gedimin45
Copy link

Steps to reproduce:

symfony new symfony-app 3.2.0-RC2
cd symfony-app
bin/console s:start
open http://127.0.0.1:8000
open http://127.0.0.1:8000/_profiler/{token}?panel=router

The exception:

An exception has been thrown during the rendering of a template ("Notice: Undefined offset: 1") in @WebProfiler/Router/panel.html.twig at line 20.

And the ContextErrorException points to vendor/symfony/symfony/src/Symfony/Component/HttpKernel/DataCollector/RequestDataCollector.php:280.
@wouterj wouterj mentioned this issue Nov 27, 2016
Merged
@wouterj
Copy link
Member

wouterj commented Nov 27, 2016

Thanks for the detailed reproduce steps! I can confirm this bug and submitted a fix in #20652

status: reviewed

nicolas-grekas added a commit that referenced this issue Nov 27, 2016
@nicolas-grekas
bug #20652 Fixed getRouteParams() when no parameters are available (w…
cb03103 
…outerj)

This PR was merged into the 3.2 branch.

Discussion
----------

Fixed getRouteParams() when no parameters are available

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20650
| License       | MIT
| Doc PR        | -

Commits
-------

040da81 Fixed getRouteParams() when no parameters are available
@gedimin45
Copy link
Author

@wouterj wow, fantastic! Thanks for the amazing work!

@javiereguiluz javiereguiluz mentioned this issue Nov 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nicolas-grekas @wouterj @gedimin45 @carsonbot