[PhpUnitBridge] weak vendors mode silence legitimate deprecations #21991
Comments
You may close this, it's the expected behavior. Only deprecations that come that a |
|
To clarify the intended usage is for libraries that want a build job to shield them from in CI errors where they trigger their own deprecations. |
|
TL;DR: Symfony is a vendor too |
|
Meh, that seems to be a missing mode then but I guess it's hard to have one that would do that 🙄 |
|
@theofidry I thought about it but regexes as a value for |
Not sure if that's the expected behaviour, but say if you have a test requesting a private service, you should get a warning along the lines of:
However if you use PhpUnitBridge with
weak_vendorsmode introduced in #21539, then this deprecation notice will be silenced.I'm not sure if that's the expected behaviour, my understanding of
weak_vendorswas that third-party deprecations, as a third-party bundle using a deprecated feature, would be silenced, not any deprecation thrown by Symfony itself triggered or not by your code.Steps to reproduce:
composer install./tests.shInside
tests.shwe can see that withweak_vendors, all deprecation notices are caught whereas without it, the deprecation notice for requesting private services is thrown (and is triggered by the user code)./cc @greg0ire
The text was updated successfully, but these errors were encountered: