Skip to content

Add min-width for debug toolbar dump section #22839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arkemlar opened this issue May 21, 2017 · 3 comments
Closed

Add min-width for debug toolbar dump section #22839

Arkemlar opened this issue May 21, 2017 · 3 comments

Comments

@Arkemlar
Copy link

Arkemlar commented May 21, 2017

Q A
Bug report? yes
Feature request? may be
BC Break report? no
RFC? no
Symfony version 3.2.8 & browser Chrome or FF (on debian based linux, last update in 2017)

Since very old symfony2 versions this issue still relevant, at least for me, I show it in two pictures:

  1. What I currently see very often:
    image
  2. How it should look like:
    image
    The only change required is adding width (for example min-width: 500px;) for CSS selector pre.sf-dump. Or make it configurable and use configurated option in dynamic styles part (<style> tag) at the end of the page, which is already starts with pre.sf-dump:
    image
@ogizanagi
Copy link
Contributor

ogizanagi commented May 21, 2017

Doesn't #20716 already solve this? The fix is available since sf 2.8.15, 3.1.8 & 3.2.1.

@Arkemlar
Copy link
Author

@ogizanagi since my sf version is 3.2.8 - looks like no :/

@mkurzeja
Copy link
Contributor

I've managed to recreate this issue on 3.2.9. I will create PR later today

mkurzeja added a commit to mkurzeja/symfony that referenced this issue May 30, 2017
mkurzeja added a commit to mkurzeja/symfony that referenced this issue May 30, 2017
fabpot added a commit that referenced this issue Jun 9, 2017
…d use full window width (mkurzeja)

This PR was merged into the 2.8 branch.

Discussion
----------

#22839 - changed debug toolbar dump section to relative and use full window width

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22839
| License       | MIT

My approach to fix #22839 - instead of adding min-width I have switched the section to fill the full available width:
![zrzut ekranu 2017-05-30 o 10 18 25](https://cloud.githubusercontent.com/assets/1044032/26574462/bf80b6dc-4521-11e7-96cc-bec0de075329.png)

Commits
-------

65297de #22839 - changed debug toolbar dump section to relative and use full window width
@fabpot fabpot closed this as completed Jun 9, 2017
This was referenced Jul 4, 2017
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
ostrolucky pushed a commit to ostrolucky/symfony that referenced this issue Mar 25, 2018
…to relative and use full window width (mkurzeja)

This PR was merged into the 2.8 branch.

Discussion
----------

symfony#22839 - changed debug toolbar dump section to relative and use full window width

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony#22839
| License       | MIT

My approach to fix symfony#22839 - instead of adding min-width I have switched the section to fill the full available width:
![zrzut ekranu 2017-05-30 o 10 18 25](https://cloud.githubusercontent.com/assets/1044032/26574462/bf80b6dc-4521-11e7-96cc-bec0de075329.png)

Commits
-------

65297de symfony#22839 - changed debug toolbar dump section to relative and use full window width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants