Skip to content

[DX][WebProfiler] Exit impersonnation link #23094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Vinorcola opened this issue Jun 7, 2017 · 3 comments
Closed

[DX][WebProfiler] Exit impersonnation link #23094

Vinorcola opened this issue Jun 7, 2017 · 3 comments
Labels
Feature WebProfilerBundle

Comments

@Vinorcola
Copy link

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Symfony version 3.x.x

It would be great to have a link to exit impersonnation in the debug toolbar the same way we have a logout link:

debug

This would be especially usefull when ending up on an exception page where there is no way to customize the template to display an exit link.
@yceruto
Copy link
Member

yceruto commented Jun 7, 2017 •
edited
Loading

There is a PR in progress for that, see #23026 :)

@yceruto yceruto mentioned this issue Jun 7, 2017
Closed
@Vinorcola
Copy link
Author

@yceruto Oh! Great!
Issue can be close then I guess!

@stof
Copy link
Member

stof commented Jun 8, 2017

issue will be closed when merging the PR then 😄

fabpot added a commit that referenced this issue Jun 21, 2017
@fabpot
feature #23026 [SecurityBundle] Add user impersonation info and exit …
2c438c5 
…action to the profiler (yceruto)

This PR was squashed before being merged into the 3.4 branch (closes #23026).

Discussion
----------

[SecurityBundle] Add user impersonation info and exit action to the profiler

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23094
| License       | MIT

Toolbar item result:

![toolbar](https://cloud.githubusercontent.com/assets/2028198/26724555/1b60320a-4768-11e7-8433-da935f7068e9.png)

I'm no sure if more information should be displayed from source token, wdyt?

Security profile panel result:

![security_token_profile_panel](https://cloud.githubusercontent.com/assets/2028198/26705860/f7a64054-4706-11e7-9eef-6cd6b7365738.png)

Commits
-------

a3253f6 [SecurityBundle] Add user impersonation info and exit action to the profiler
@fabpot fabpot closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @stof @xabbuh @yceruto @Vinorcola