Skip to content

simple-phpunit looping until the root #25228

New issue
New issue
Closed
Closed
simple-phpunit looping until the root#25228
Labels
BugPhpUnitBridgeStatus: Needs Review
@greg0ire

Description

@greg0ire
greg0ire
opened on Nov 30, 2017
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.4.0

#25068 introduced a bug when using bin-dir: bin in Composer.

This condition will always return true until / is reached:

symfony/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit

Lines 30 to 35 in bd4fe8d

while (!file_exists($root.'/composer.json') || file_exists($root.'/bin/simple-phpunit')) {
if ($root === dirname($root)) {
break;
}
$root = dirname($root);
}

A simple workaround is to avoid using bin as a bin-dir.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugPhpUnitBridgeStatus: Needs Review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions