Skip to content

[Config] canBeEnabled() not properly handling null #25862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh opened this issue Jan 20, 2018 · 3 comments
Closed

[Config] canBeEnabled() not properly handling null #25862

xabbuh opened this issue Jan 20, 2018 · 3 comments
Labels
BC Break Bug Config Status: Needs Review

Comments

@xabbuh
Copy link
Member

xabbuh commented Jan 20, 2018 •
edited
Loading

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version all not yet released

#25789 seems to have broken the handling for null values if a (nested) array node can be enabled (this can be easily reproduced by using null instead of the nested enabled node in the changes made in #25847.
@fabpot fabpot mentioned this issue Jan 21, 2018
Closed
@fabpot
Copy link
Member

fabpot commented Jan 21, 2018

PR reverted

@fabpot fabpot closed this as completed Jan 21, 2018
@mateuszsip
Copy link
Contributor

Reproducer: 38a5d64

@mateuszsip
Copy link
Contributor

And that's the line converting NULL to []:
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Loader/YamlFileLoader.php#L772

@mateuszsip mateuszsip mentioned this issue Jan 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Bug Config Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @mateuszsip @xabbuh @carsonbot