Skip to content

[Routing] Allow force-generation of trailing parameters using eg "/exports/news.{!_format}" #29593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue Dec 13, 2018 · 1 comment
Closed

[Routing] Allow force-generation of trailing parameters using eg "/exports/news.{!_format}" #29593

nicolas-grekas opened this issue Dec 13, 2018 · 1 comment
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.

Comments

@nicolas-grekas
Copy link
Member

When a route is defined as path: '/exports/news.{!_format}', we should force _format be defined in "defaults" and the generator should generate URLs with that default when none is provided (should work with any parameter of course.)

Better described in #28633 (comment)
@nicolas-grekas nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Dec 13, 2018
@nicolas-grekas nicolas-grekas mentioned this issue Dec 13, 2018
Closed
@luchaninov luchaninov mentioned this issue Dec 13, 2018
Merged
nicolas-grekas added a commit that referenced this issue Dec 24, 2018
@nicolas-grekas
feature #29599 [Routing] Allow force-generation of trailing parameter…
57dad66 
…s using eg "/exports/news.{!_format}" (zavulon)

This PR was squashed before being merged into the 4.3-dev branch (closes #29599).

Discussion
----------

[Routing] Allow force-generation of trailing parameters using eg "/exports/news.{!_format}"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29593
| License       | MIT

When a route is defined as path: `/exports/news.{!_format}`, we should force `_format` be defined in `defaults` and the generator should generate URLs with that default when none is provided (should work with any parameter of course).

Commits
-------

9fab3d6 [Routing] Allow force-generation of trailing parameters using eg \"/exports/news.{!_format}\"
@Tobion
Copy link
Contributor

Tobion commented Dec 24, 2018

Ref. #5180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help wanted Issues and PRs which are looking for volunteers to complete them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolas-grekas @Tobion