Skip to content

[RFC] Change gender choice types to be more inclusive #29737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mx-Glitter opened this issue Dec 31, 2018 · 4 comments
Closed

[RFC] Change gender choice types to be more inclusive #29737

Mx-Glitter opened this issue Dec 31, 2018 · 4 comments

Comments

@Mx-Glitter
Copy link
Contributor

I saw here that we use the example of gender for choice forms often. There are a lot of instances where we list 2 genders male and female as the only options, I was wondering if we should perhaps change it to be more inclusive (I myself being non-binary would like to be included for example). I'm aware it sounds nitpicking, but with the diversity initiative I figure I should ask.

I see 3 solutions, sorted from the my most prefered first:

  • Not using gender as an example of choice form, because it is most of the times unnecessary for websites to ask such information, so we should not give it as an example as it promotes a bad habit.
  • Using a list with "male", "female" and "non-binary", to include more people.
  • Using a list with "male", "female" and "other", what is currently done in several places already in Symfony code and docs, I prefer the previous one not to be refered as other which is a bit demeaning.
@fabpot
Copy link
Member

fabpot commented Jan 1, 2019

I would also favor the first option.

@xabbuh
Copy link
Member

xabbuh commented Jan 2, 2019

I also think that option 1 is the best solution.

@derrabus
Copy link
Member

derrabus commented Jan 2, 2019

If we pick option 1, what would be a better default example? Colors maybe?

For instance https://github.com/symfony/form/blob/63fb6bcbb38676958731da428007671b24963cec/Forms.php#L29-L31

->add('color', 'Symfony\Component\Form\Extension\Core\Type\ChoiceType', array(
    'choices' => array('Red' => 'r', 'Blue' => 'b'),
))

@Mx-Glitter
Copy link
Contributor Author

I'll have a go at it this week-end

This was referenced Jan 5, 2019
Closed
Closed
Closed
Merged
fabpot added a commit that referenced this issue Jan 5, 2019
@fabpot
minor #29788 Changed gender choice types to color (aaronsomi)
8555ffc 
This PR was merged into the 3.4 branch.

Discussion
----------

Changed gender choice types to color

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      |no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29737  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

Commits
-------

fdf98af Changed gender choice types to color
This was referenced Jan 26, 2019
Merged
Merged
nicolas-grekas added a commit that referenced this issue Jan 26, 2019
@nicolas-grekas
minor #29994 Replace gender by eye color in tests (Raphaëll Roussel)
dc8c506 
This PR was merged into the 3.4 branch.

Discussion
----------

Replace gender by eye color in tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29737   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

I've slightly changed @derrabus proposition to use color only because of the potentially racist interpretation when used for a person, open for discussion though.

Commits
-------

7218034 Replace gender by eye color in tests
@Mx-Glitter Mx-Glitter mentioned this issue Jan 26, 2019
Merged
fabpot added a commit to symfony/polyfill that referenced this issue Jan 27, 2019
@fabpot
minor #165 Replace gender by eye color (Raphaëll Roussel)
6ff8ece 
This PR was merged into the 1.10-dev branch.

Discussion
----------

Replace gender by eye color

Fixes symfony/symfony#29737 but in polyfill

Commits
-------

53f2a4d Replace gender by eye color
javiereguiluz added a commit to symfony/symfony-docs that referenced this issue Jan 28, 2019
@javiereguiluz
minor #10931 Change gender to eye color (Mx-Glitter)
7778424 
This PR was merged into the 3.4 branch.

Discussion
----------

Change gender to eye color

Fixes symfony/symfony#29737 in documentation

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

f63ee2f Change gender to eye-color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fabpot @nicolas-grekas @derrabus @xabbuh @Mx-Glitter