-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Disable var-dumper search #29748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That's the main reason for this feature at least :) personally im very used to it. Perhaps we can do something like #29528 and allow to disable custom search with e.g. |
instead of binding CTRL+F, a small magnifying glass could open the search feature? |
I like the magnifying glass button (or any button). The everywhere search can be useful, but usually I click open a few sections and then browser search. The var-dumper search then messes up the expansions and focus and scroll location etc. I'd still like to use Where are all these config options? I couldn't find any on https://symfony.com/doc/current/components/var_dumper.html |
I won't be in favor of removing the CTRL + F binding unless more people express themselves about this being annoying by default. This is the natural way to trigger such a feature and the binding is only listened when having focus on the A small magnifying glass might be fine but is one more absolutely positioned thingy we could save us IMHO. Though it would ease discoverability. I agree as well about saving us from another config option for this. |
I think @ogizanagi is right. Let's close for now. |
…ouble CMD/CTRL + F (ogizanagi) This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29748 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Simple way to enhance DX & mitigate #29748 Commits ------- d243058 [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit
The
CTRL + F
capture in Var-dumper keeps tripping me up. I don't want to use this weird search feature. I know where I'm looking, so I'll use the browser search function. It's very very hard-coded however. It'd be nice toCTRL+F
capture (so open search with a button or something)The text was updated successfully, but these errors were encountered: