Skip to content

Disable var-dumper search #29748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rudiedirkx opened this issue Jan 2, 2019 · 5 comments
Closed

Disable var-dumper search #29748

rudiedirkx opened this issue Jan 2, 2019 · 5 comments

Comments

@rudiedirkx
Copy link

The CTRL + F capture in Var-dumper keeps tripping me up. I don't want to use this weird search feature. I know where I'm looking, so I'll use the browser search function. It's very very hard-coded however. It'd be nice to

  • disable it completely, or
  • disable the CTRL+F capture (so open search with a button or something)
@ro0NL
Copy link
Contributor

ro0NL commented Jan 3, 2019

#20873

Generally as long as the data structures are not expanded they are not searchable via the browser search.

That's the main reason for this feature at least :) personally im very used to it.

Perhaps we can do something like #29528 and allow to disable custom search with e.g. debug.search_dump: false.

@nicolas-grekas
Copy link
Member

instead of binding CTRL+F, a small magnifying glass could open the search feature?
let's save us from yet another config option is possible, please.

@rudiedirkx
Copy link
Author

I like the magnifying glass button (or any button). The everywhere search can be useful, but usually I click open a few sections and then browser search. The var-dumper search then messes up the expansions and focus and scroll location etc.

I'd still like to use dump() and dd(). I don't how how config would be injected.

Where are all these config options? I couldn't find any on https://symfony.com/doc/current/components/var_dumper.html

@ogizanagi
Copy link
Contributor

I won't be in favor of removing the CTRL + F binding unless more people express themselves about this being annoying by default. This is the natural way to trigger such a feature and the binding is only listened when having focus on the pre.sf-dump element.
To use native browser search feature, you simply have to click outside or press tab if you had focus.

A small magnifying glass might be fine but is one more absolutely positioned thingy we could save us IMHO. Though it would ease discoverability.

I agree as well about saving us from another config option for this.

@fabpot
Copy link
Member

fabpot commented Jan 4, 2019

I think @ogizanagi is right. Let's close for now.

@fabpot fabpot closed this as completed Jan 4, 2019
fabpot added a commit that referenced this issue Jul 8, 2019
…ouble CMD/CTRL + F (ogizanagi)

This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] Let browsers trigger their own search on double CMD/CTRL + F

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29748   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Simple way to enhance DX & mitigate #29748

Commits
-------

d243058 [VarDumper] Let browsers trigger their own search on double CMD/CTRL + F hit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants