Skip to content

HttpKernel *HttpException should depend on HttpResponse constants #30072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Geolim4 opened this issue Feb 4, 2019 · 2 comments
Closed

HttpKernel *HttpException should depend on HttpResponse constants #30072

Geolim4 opened this issue Feb 4, 2019 · 2 comments
Labels
HttpKernel

Comments

@Geolim4
Copy link

Geolim4 commented Feb 4, 2019

Symfony version(s) affected: 3,4

Description
Currently HttpKernel *HttpException are hardcoding statusCode in child constructor.

How to reproduce
Not reproducible as it's part of the current code

Possible Solution
As httpKernel depends on HttpFoundation, those statusCode should refer directly to HttpFoundation/Response class constants.

Additional context
N/A
@Geolim4
Copy link
Author

Geolim4 commented Feb 4, 2019

If the "bug" is confirmed, I can provide a PR asap.

@javiereguiluz
Copy link
Member

@Geolim4 thank you for your proposal! Sadly, I'm afraid this has been proposed in the past (see for example #22023) and rejected because of the reason given in #22023 (comment)

So, we must close this as "won't fix". I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpKernel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @Geolim4 @xabbuh