Skip to content

[Validator] Add the missing translations for the Danish ("da") locale #30155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 12, 2019 · 8 comments
Closed

[Validator] Add the missing translations for the Danish ("da") locale #30155

javiereguiluz opened this issue Feb 12, 2019 · 8 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2019 •
edited
Loading

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!

Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.da.xlf file is missing the following translations compared to the original English file:

<trans-unit id="64">
    <source>This value is not a valid currency.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="65">
    <source>This value should be equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="66">
    <source>This value should be greater than {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="67">
    <source>This value should be greater than or equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="68">
    <source>This value should be identical to {{ compared_value_type }} {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="69">
    <source>This value should be less than {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="70">
    <source>This value should be less than or equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="71">
    <source>This value should not be equal to {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="72">
    <source>This value should not be identical to {{ compared_value_type }} {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="73">
    <source>The image ratio is too big ({{ ratio }}). Allowed maximum ratio is {{ max_ratio }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="74">
    <source>The image ratio is too small ({{ ratio }}). Minimum ratio expected is {{ min_ratio }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="75">
    <source>The image is square ({{ width }}x{{ height }}px). Square images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="76">
    <source>The image is landscape oriented ({{ width }}x{{ height }}px). Landscape oriented images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="77">
    <source>The image is portrait oriented ({{ width }}x{{ height }}px). Portrait oriented images are not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="78">
    <source>An empty file is not allowed.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="79">
    <source>The host could not be resolved.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="80">
    <source>This value does not match the expected {{ charset }} charset.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="81">
    <source>This is not a valid Business Identifier Code (BIC).</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="87">
    <source>This collection should contain only unique elements.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="88">
    <source>This value should be positive.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="89">
    <source>This value should be either positive or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="90">
    <source>This value should be negative.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="91">
    <source>This value should be either negative or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="92">
    <source>This value is not a valid timezone.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="93">
    <source>This password has been leaked in a data breach, it must not be used. Please use another password.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="94">
    <source>This value should be between {{ min }} and {{ max }}.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.
@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@gudfar gudfar mentioned this issue May 14, 2019
Merged
fabpot added a commit that referenced this issue May 15, 2019
@fabpot
minor #31499 [Validator] Add the missing translations for the Danish …
01964c8 
…("da") locale (gauss)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add the missing translations for the Danish ("da") locale

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30155
| License       | MIT

Addresses the missing translations listed in #30155

Commits
-------

710f8a6 [Validator] Add the missing translations for the Danish ("da") locale
@mauran
Copy link

mauran commented Jun 30, 2019

Seems like this issue is already done and needs to be closed if I'm right. :)

@xabbuh xabbuh closed this as completed Jun 30, 2019
@javiereguiluz
Copy link
Member Author

I'm reopening this because this is not fixed yet.

@mauran that Danish translation file exists (see https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Validator/Resources/translations/validators.da.xlf) but it doesn't contain yet the translations listed in this issue. The work to do is to add only these missing translations to the existing file. Thanks for offering yourself to do it!

@javiereguiluz javiereguiluz reopened this Jun 30, 2019
@javiereguiluz
Copy link
Member Author

Sorry for the confusion ... these strings were indeed translated in #31499 .... but they were merged in the wrong file. They should go to Validator component, not Form component 🤔

@mauran
Copy link

mauran commented Jun 30, 2019

Ohh 😅 - So should i just move them to their correct place to be?

@xabbuh
Copy link
Member

xabbuh commented Jul 8, 2019

@mauran Would you like to give it a try?

@mauran
Copy link

mauran commented Jul 12, 2019

@xabbuh Yeah! But i'm still unsure if i just need to move the translation-files or not. :)

@xabbuh
Copy link
Member

xabbuh commented Jul 13, 2019

@mauran We do not need to move the files. The content that was present before can stay there. We only need to move the entries added in #31499.

@xabbuh xabbuh mentioned this issue Aug 9, 2019
Merged
@xabbuh
Copy link
Member

xabbuh commented Aug 9, 2019

see #33085

@fabpot fabpot closed this as completed Aug 9, 2019
fabpot added a commit that referenced this issue Aug 9, 2019
@fabpot
minor #33085 [Validator] fix Danish translations (xabbuh)
c474e34 
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] fix Danish translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30155
| License       | MIT
| Doc PR        |

Commits
-------

6e0c916 fix Danish translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @mauran @xabbuh