-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] Add the missing translations for the Dutch ("nl") locale #30177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I like to pick this one |
…nl) locale (reyostallenberg) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Add the missing translations for the Dutch (nl) locale | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30177 | License | MIT This PR addresses the issue #30177, adding the missing translations for the Dutch (nl) locale. Commits ------- 0266238 [Validator] Add the missing translations for the Dutch (nl) locale
@javiereguiluz any idea how number 84 went missing? I suggested it in the original PR and it was merged like that. So I'm pretty surprised it got lost along the way as it was most recently missing before this issue today...? |
Hang on I see, the feature went into |
@curry684 yes, to make things easier to maintain, it's been decided to include all translations in the lowest maintained branch ... even if those are not used in that branch. Thanks. |
Ah ok, wasn't aware of that, thanks for clarifying 👍 |
IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.
If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!
Symfony version(s) affected: 3.4
Description
The
src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf
file is missing the following translations compared to the original English file:Possible Solution
A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.
Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.
Additional context
You have two ways to make this contribution:
1) Use the GitHub web interface to edit the translation and make the pull request.
2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.
If you need any help during the contribution process, visit the
#contribs
channel on Symfony Slack where we'll be happy to help you.The text was updated successfully, but these errors were encountered: