Skip to content

[Validator] Add the missing translations for the Dutch ("nl") locale #30177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Feb 12, 2019 · 5 comments
Closed
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone

Comments

@javiereguiluz
Copy link
Member

IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!


Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.nl.xlf file is missing the following translations compared to the original English file:

<trans-unit id="79">
    <source>The host could not be resolved.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.

@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@reyostallenberg
Copy link
Contributor

I like to pick this one

fabpot added a commit that referenced this issue Feb 12, 2019
…nl) locale (reyostallenberg)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add the missing translations for the Dutch (nl) locale

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30177
| License       | MIT

This PR addresses the issue #30177, adding the missing translations for the Dutch (nl) locale.

Commits
-------

0266238 [Validator] Add the missing translations for the Dutch (nl) locale
@fabpot fabpot closed this as completed Feb 12, 2019
@curry684
Copy link
Contributor

@javiereguiluz any idea how number 84 went missing? I suggested it in the original PR and it was merged like that. So I'm pretty surprised it got lost along the way as it was most recently missing before this issue today...?

@curry684
Copy link
Contributor

Hang on I see, the feature went into master and this PR is targetting 3.4, why are we backporting translations to versions that don't contain their usage?

@javiereguiluz
Copy link
Member Author

@curry684 yes, to make things easier to maintain, it's been decided to include all translations in the lowest maintained branch ... even if those are not used in that branch. Thanks.

@curry684
Copy link
Contributor

Ah ok, wasn't aware of that, thanks for clarifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Development

No branches or pull requests

4 participants