Skip to content

[Validator] Add the missing translations for the Tagalog ("tl") locale #30192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Closed

[Validator] Add the missing translations for the Tagalog ("tl") locale #30192

javiereguiluz opened this issue Feb 12, 2019 · 2 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Milestone
3.4

Comments

@javiereguiluz
Copy link
Member

javiereguiluz commented Feb 12, 2019 •
edited
Loading

IMPORTANT: this issue is reserved for new contributors, because we want to give the opportunity to people who want to contribute to Symfony but never found the right issue to do that.

If you want to work on this issue, add a comment to assign it to yourself and let others know that this is already taken. Thanks!

Symfony version(s) affected: 3.4

Description

The src/Symfony/Component/Validator/Resources/translations/validators.tl.xlf file is missing the following translations compared to the original English file:

<trans-unit id="82">
    <source>Error</source>
    <target>...</target>
</trans-unit>
<trans-unit id="83">
    <source>This is not a valid UUID.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="84">
    <source>This value should be a multiple of {{ compared_value }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="85">
    <source>This Business Identifier Code (BIC) is not associated with IBAN {{ iban }}.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="86">
    <source>This value should be valid JSON.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="87">
    <source>This collection should contain only unique elements.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="88">
    <source>This value should be positive.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="89">
    <source>This value should be either positive or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="90">
    <source>This value should be negative.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="91">
    <source>This value should be either negative or zero.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="92">
    <source>This value is not a valid timezone.</source>
    <target>...</target>
</trans-unit>
<trans-unit id="93">
    <source>This password has been leaked in a data breach, it must not be used. Please use another password.</source>
    <target>...</target>
</trans-unit>

Possible Solution

A Pull Request must be sent to Symfony's 3.4 branch adding the missing translations.

Don't forget to take a quick look at the existing translations to use the same tone and style in the new translations.

Additional context

You have two ways to make this contribution:

1) Use the GitHub web interface to edit the translation and make the pull request.

  • It's recommended if you don't have any experience using Git in the terminal.
  • To do so, click here to edit the translation file and follow the given steps to create the pull request.

2) Use your own editor to edit the translation file and use the Git commands in the terminal to make the pull request.

  • It's the most common way to contribute to Symfony.
  • You need to download Symfony's code to your computer and follow the steps explained in this contribution guide

If you need any help during the contribution process, visit the #contribs channel on Symfony Slack where we'll be happy to help you.
@javiereguiluz javiereguiluz added Validator Good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Feb 12, 2019
@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 12, 2019
@johnillo
Copy link
Contributor

@javiereguiluz , I'd like to take this one as my good first issue.

@javiereguiluz
Copy link
Member Author

@johnillo great! Thank you very much. If you need any help, please ask us in Symfony's Slack.

@johnillo johnillo mentioned this issue Apr 16, 2019
Merged
fabpot pushed a commit that referenced this issue Apr 17, 2019
@nicolas-grekas
minor #31128 [Validator] Added the missing translations for the Tagal…
f458e5b 
…og ("tl") locale (johnillo)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Added the missing translations for the Tagalog ("tl") locale

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | No
| New feature?  | No
| BC breaks?    | No
| Deprecations? | No
| Tests pass?   | Yes
| Fixed tickets | #30192
| License       | MIT
| Doc PR        |

[Validator] This pull request will add the missing translations for the Tagalog ("tl") locale.

Commits
-------

6ab574b [Validator] #30192 Added the missing translations for the Tagalog ("tl") locale.
fabpot pushed a commit that referenced this issue Apr 17, 2019
@nicolas-grekas
Merge branch '3.4' into 4.2
6aec217 
* 3.4:
  Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"
  [FrameworkBundle] minor: remove a typo from changelog
  [VarDumper][Ldap] relax some locally failing tests
  [Validator] #30192 Added the missing translations for the Tagalog ("tl") locale.
  Make MimeTypeExtensionGuesser case insensitive
fabpot pushed a commit that referenced this issue Apr 17, 2019
@nicolas-grekas
Merge branch '4.2'
8d96861 
* 4.2:
  Revert "bug #30423 [Security] Rework firewall's access denied rule (dimabory)"
  [FrameworkBundle] minor: remove a typo from changelog
  [VarDumper] fix tests with ICU 64.1
  [VarDumper][Ldap] relax some locally failing tests
  [Validator] #30192 Added the missing translations for the Tagalog ("tl") locale.
  Make MimeTypeExtensionGuesser case insensitive
  Fix get session when the request stack is empty
  [Routing] fix trailing slash redirection with non-greedy trailing vars
  [FrameworkBundle] decorate the ValidatorBuilder's translator with LegacyTranslatorProxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Validator
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
3 participants
@javiereguiluz @nicolas-grekas @johnillo