[Mailer] Dynamically Change Transport using getTransport in Mailer Class #32523

alingabrieldm · 2019-07-12T16:46:47Z

Is it a good idea to introduce the getTransport method into the Mailer class so that it can be modified?

I did this because it seemed to me the easiest way to solve the problem of sending emails via SMTP, using authentication data stored in the database (in my case in Website entities);

// vendor/symfony/mailer/Mailer.php

...
class Mailer implements MailerInterface
{
    ...
    public function getTransport() : TransportInterface {
        return $this->transport;
    }
    ...
}

// and in my service:

public function __construct(
    Symfony\Component\Mailer\MailerInterface $mailer
){
    $this->mailer = $mailer;
}

public function getMailer(Website $website){
    $this->mailer->getTransport()
    ->setUsername($website->getSmtpUsername())
    ->setPassword($website->getSmtpPassword());

    $transport->getStream()
    ->setHost($website->getSmtpHost())
    ->setPort($website->getSmtpPort());

    return $this->mailer;
}

Koc · 2019-07-14T14:50:46Z

easiest way to solve the problem of sending emails via SMTP, using authentication data stored in the database (in my case in Website entities)

It would be possible by creating custom Transport Factory once #31946 be merged.

…stom transports (Koc) This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Extract transport factory and allow create custom transports | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes, failure unrelated (master hasn't this PR) | Fixed tickets | #31385, #32523 | License | MIT | Doc PR | TBD Alternative approach to allow create custom transports and register DSN for it. Replaces #31931, #31935 . Similar to already existent TansportFactory from Messenger. TODO: - [x] Update changelog - [x] Add more tests for factories - [x] Add test for configuration + DI extension Commits ------- 5b9cded Add transport factories (closes #31385, closes #32523)

* 4.4: [WebProfilerBundle] Remove unneeded information in the routing panel Add transport factories (closes #31385, closes #32523) [Lock] remove uusage of the StoreInterface [HttpClient] make toStream() throw by default [Mailer] added XML configuration for the mailer envelope added missing test [Mailer] Allow register mailer configuration in xml format [VarDumper] Allow to configure VarDumperTestTrait casters & flags Improve errors when trying to find a writable property [Lock] add aliases for LockFactory fixed CS fix some deprecations and add upgrade instructions fix typo Added Nl translations fixed CS [FrameworkBundle] Fix descriptor of routes described as callable array [Debug][DebugClassLoader] Include found files instead of requiring them [HttpKernel] fix tests Adding missing event_dispatcher wiring for messenger.middleware.send_message

javiereguiluz added Feature Mailer labels Jul 13, 2019

Koc mentioned this issue Jul 14, 2019

[Mailer] Extract transport factory and allow create custom transports #31946

Merged

3 tasks

Koc added a commit to Koc/symfony that referenced this issue Jul 14, 2019

Add transport factories (closes symfony#31385, symfony#32523)

29d9a30

Koc added a commit to Koc/symfony that referenced this issue Jul 14, 2019

Add transport factories (closes symfony#31385, closes symfony#32523)

5029ed6

Koc added a commit to Koc/symfony that referenced this issue Jul 16, 2019

Add transport factories (closes symfony#31385, closes symfony#32523)

5b9cded

fabpot closed this as completed Jul 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mailer] Dynamically Change Transport using getTransport in Mailer Class #32523

[Mailer] Dynamically Change Transport using getTransport in Mailer Class #32523

alingabrieldm commented Jul 12, 2019 •

edited by javiereguiluz

Loading

Koc commented Jul 14, 2019

[Mailer] Dynamically Change Transport using getTransport in Mailer Class #32523

[Mailer] Dynamically Change Transport using getTransport in Mailer Class #32523

Comments

alingabrieldm commented Jul 12, 2019 • edited by javiereguiluz Loading

Koc commented Jul 14, 2019

alingabrieldm commented Jul 12, 2019 •

edited by javiereguiluz

Loading