Skip to content

[Messenger] Retry Transport does not send the message back to retry transport on failing #33685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BrentRobert opened this issue Sep 24, 2019 · 1 comment

Comments

@BrentRobert
Copy link

Symfony version(s) affected: 4.3.3

Description
When using the messenger:failed:retry command, the message is retried immediately. When it fails again, it should be requeued to the failure transport, but this does not happen due to the following code in the SendFailedMessageToFailureTransportListener class

 // avoid re-sending to the failed sender
        if (null !== $envelope->last(SentToFailureTransportStamp::class)) {
            return;
        }

Is this expected behavior?

How to reproduce
Let a handler fail and queue it to the failure transport. Retry the message using the messenger:failed:retry command

@Tobion
Copy link
Contributor

Tobion commented Oct 24, 2019

I also understood this wrong at first.
But the failed message will be sent back to the failure transport depending on the retry strategy of the failure transport (which is enabled by default). So yes it is going back to the failure transport under normal circumstances.
See #32341 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants