Skip to content

[HttpClient] implement async client #33710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garak opened this issue Sep 25, 2019 · 4 comments · Fixed by #33743
Closed

[HttpClient] implement async client #33710

garak opened this issue Sep 25, 2019 · 4 comments · Fixed by #33743
Labels
Feature Help wanted Issues and PRs which are looking for volunteers to complete them. HttpClient
Milestone
4.4

Comments

@garak
Copy link
Contributor

garak commented Sep 25, 2019

It would be nice to implement php-http/async-client-implementation
@nicolas-grekas
Copy link
Member

This could be added to HttplugClient I suppose. We have all the code infrastructure, so it's "just" a matter of writing the implementation :)

Help wanted.

@nicolas-grekas nicolas-grekas added the Help wanted Issues and PRs which are looking for volunteers to complete them. label Sep 25, 2019
@javiereguiluz javiereguiluz added this to the next milestone Sep 26, 2019
@nicolas-grekas
Copy link
Member

Could be of interest: getsentry/sentry-php#878 (comment)

@B-Galati
Copy link
Contributor

I see some implementation (like Curl one from Httplug) that do not start the request when calling sendAsyncRequest. What should we do with this one?

IMHO it's better to start the request ASAP but not sure it fits with the specifications.

@B-Galati B-Galati mentioned this issue Sep 26, 2019
Closed
@Nyholm Nyholm mentioned this issue Sep 27, 2019
Merged
@Nyholm
Copy link
Member

Nyholm commented Sep 27, 2019

I crafted a PR for this feature. I really want some reviews or someone to test this for me.

#33743

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Help wanted Issues and PRs which are looking for volunteers to complete them. HttpClient
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

[HttpClient] Async HTTPlug client Nyholm/symfony
5 participants
@javiereguiluz @garak @nicolas-grekas @B-Galati @Nyholm