Skip to content

Optionally fail for deprecations in our various lint commands #33957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stof opened this issue Oct 11, 2019 · 2 comments · Fixed by #33961
Closed

Optionally fail for deprecations in our various lint commands #33957

stof opened this issue Oct 11, 2019 · 2 comments · Fixed by #33961

Comments

@stof
Copy link
Member

stof commented Oct 11, 2019

A common use case for the lint commands (lint:yaml, lint:twig and lint:xliff) is to run them on CI.
While they report syntax errors currently, they don't allow failing when a deprecated feature is used (this is relevant at least for twig and yaml today). If would be great if they could have an option that would turn on reporting of any deprecation triggered as part of the parsing rather than only reporting parsing errors. This way, the CI can also prevent using deprecated Twig/YAML features.

@chalasr
Copy link
Member

chalasr commented Oct 11, 2019

lint:yaml already reports deprecation notices as parse errors since #22274.
👍for doing the same for twig and making it opt-in.

@yceruto
Copy link
Member

yceruto commented Oct 11, 2019

👍 PR for lint:twig here #33961

@fabpot fabpot closed this as completed in 6253369 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants