Skip to content

[Serializer] MetadataAwareNameConverter break groups parameters #34455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gilles-g opened this issue Nov 19, 2019 · 2 comments
Closed

[Serializer] MetadataAwareNameConverter break groups parameters #34455

gilles-g opened this issue Nov 19, 2019 · 2 comments
Labels
Bug Serializer Status: Needs Review

Comments

@gilles-g
Copy link

gilles-g commented Nov 19, 2019 •
edited
Loading

Symfony version(s) affected: 4.3.7

Description
Since #34035, cannot denormalize with that syntax ['groups' => 'user']

How to reproduce

$obj = $normalizer->denormalize(['bar' => 'Api Platform'], Foo::class, null, ['groups' => 'user']);

-->

/**
In MetadataAwareNameConverter.php line 126:
                                                                                 
Warning: array_intersect(): Expected parameter 2 to be an array, string given
*/

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Serializer/NameConverter/MetadataAwareNameConverter.php#L126

Possible Solution

@antograssiot If you could have a look at this

Additional context
@bizley
Copy link

bizley commented Nov 19, 2019

I can confirm the same problem. Changing the groups value to array helped. Possible solution is the array cast in this line:

if ($groups && !array_intersect($groups, (array)$context[AbstractNormalizer::GROUPS] ?? [])) {

@antograssiot antograssiot mentioned this issue Nov 21, 2019
Merged
@antograssiot
Copy link
Contributor

I just submitted a fix, apologies for that 😞

nicolas-grekas added a commit that referenced this issue Nov 28, 2019
@nicolas-grekas
bug #34490 [Serializer] Fix MetadataAwareNameConverter usage with str…
33731bf 
…ing group (antograssiot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Serializer] Fix MetadataAwareNameConverter usage with string group

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34455
| License       | MIT
| Doc PR        |

Allow to use the short syntax for serialization context group like `['groups' => 'user']`

Commits
-------

d4f749a [Serializer] Fix MetadataAwareNameConverter usage with string group
soyuka added a commit to soyuka/core that referenced this issue Aug 31, 2020
@soyuka
Use symfony/serializer >= 4.4.1 to fix
1b1dd82 
symfony/symfony#34455
soyuka added a commit to soyuka/core that referenced this issue Aug 31, 2020
@soyuka
Use symfony/serializer >= 4.4.1 to fix
74d9a0d 
symfony/symfony#34455
soyuka added a commit to soyuka/core that referenced this issue Aug 31, 2020
@soyuka
Use symfony/serializer >= 4.4.9 to fix issues:
a9e0a30 
symfony/symfony#34455
symfony/symfony#36601
soyuka added a commit to soyuka/core that referenced this issue Aug 31, 2020
@soyuka
Use symfony/serializer >= 4.4.9 to fix issues:
73affae 
symfony/symfony#34455
symfony/symfony#36601
soyuka added a commit to soyuka/core that referenced this issue Aug 31, 2020
@soyuka
Use symfony/serializer >=4.4.9-5.0.9 to fix issues
173ff43 
symfony/symfony#34455
symfony/symfony#36601
soyuka added a commit to api-platform/core that referenced this issue Sep 1, 2020
@soyuka
Fix tests (#3698)
2c87089 
* Use symfony/serializer >=4.4.9-5.0.9 to fix issues

symfony/symfony#34455
symfony/symfony#36601

* Lowest + legacy test suite missing git

* fix Symfony 5 router generate with reference type
hultberg pushed a commit to hultberg/symfony that referenced this issue Sep 17, 2021
@nicolas-grekas
bug symfony#34490 [Serializer] Fix MetadataAwareNameConverter usage w…
495adc5 
…ith string group (antograssiot)

This PR was merged into the 4.3 branch.

Discussion
----------

[Serializer] Fix MetadataAwareNameConverter usage with string group

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix symfony#34455
| License       | MIT
| Doc PR        |

Allow to use the short syntax for serialization context group like `['groups' => 'user']`

Commits
-------

d4f749a [Serializer] Fix MetadataAwareNameConverter usage with string group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nicolas-grekas @gilles-g @xabbuh @antograssiot @bizley @carsonbot