Skip to content

Service Container Linter and object typehint #34480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pfazzi opened this issue Nov 21, 2019 · 1 comment
Closed

Service Container Linter and object typehint #34480

pfazzi opened this issue Nov 21, 2019 · 1 comment
Labels
Bug DependencyInjection Status: Needs Review

Comments

@pfazzi
Copy link
Contributor

pfazzi commented Nov 21, 2019

Symfony version(s) affected: 4.4.0

Description
When i execute lint:container i get this error:

$> symfony console lint:container

In CheckTypeDeclarationsPass.php line 159:

   Invalid definition for service "sylius.translation.translatable_listener.doctrine.orm": argument 2 of 
   "Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener::__construct"
   accepts "object", "Sylius\Component\Core\Translation\TranslatableEntityLocaleAssigner" passed.

Is it correct that service container linter has this behaviour against object typehint?
@xabbuh xabbuh mentioned this issue Nov 22, 2019
Merged
@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2019

see #34515

@fabpot fabpot closed this as completed Nov 25, 2019
fabpot added a commit that referenced this issue Nov 25, 2019
@fabpot
bug #34515 [DependencyInjection] definitions are valid objects (xabbuh)
f6c4b67 
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] definitions are valid objects

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34480
| License       | MIT
| Doc PR        |

Commits
-------

0acaa5c definitions are valid objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @xabbuh @pfazzi @carsonbot