Skip to content

[DI] XmlDumper looses parameters types while dumping #34689

Closed
@andrew-demb

Description

@andrew-demb

Symfony version(s) affected: 4.4.0

Description

XmlDumper doesn't preserve container parameter types.
Use any numeric-like parameter in container parameter value leads to have loaded value type float|int from xml cache.

How to reproduce

Use parameter with value something like '+1238523'.
Expected loaded value: string(8) "+1238523"
Actual loaded value: double(1238523)

Reproducer:
https://gist.github.com/andrew-demb/02c8487cd1a457f3d37d20c7afedd76c

Possible Solution

Support more cases here and set needed type attribute.
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php#L316-L320

Additional context

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions