-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
The translation:update command should be aware of the +intl-icu variant #34713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The |
would that mean you should also update the suffix in the code to make it work properly? {% trans_default_domain 'messages+intl-icu' %} It works, but @nicolas-grekas (as author of this code) can confirm it better. |
Nope, there should be no need to update the code/template. |
@yceruto |
Okay, so it's a buggy behavior related to the
I think it will depend:
but also if we are updating an existing (single) file, we must keep the domain attached to it, regardless whether Intl ext is installed or not. And if both files exist ( Can you confirm that's what we want before make the changes? |
@yceruto LGTM! |
ready for review #34797 |
This PR was merged into the 4.4 branch. Discussion ---------- [Translation] Fix FileDumper behavior | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34713 | License | MIT | Doc PR | - Execute `bin/console translation:update --force en` command: ## Before See related issue for details #34713 ## After The default translation file name will depend on whether the intl (or polyfill) extension is installed or not. For exmaple: | Intl extension (or polyfill) installed | translation file created | | --- | --- | | no | messages.en.xlf | | yes | messages+intl-icu.en.xlf | However, if you are currently updating a single file, that file name will be used regardless of whether the Intl extension is installed, i.e. if you have this translation file: `messages.en.xlf`, new translation keys will be stored in it, even if you have installed the intl extension. Last, if both translation files (`messages.es.xlf` and `messages+intl-icu.en.xlf`) coexist in the same path, rare but possible, we will use the default filename guessed earlier to store all current messages and the another file will be emptied. Commits ------- 1c41ae7 Fixed translations file dumper behavior
…fix #34713 (yceruto) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- Revert #34797 "Fixed translations file dumper behavior" and fix #34713 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #35264 | License | MIT | Doc PR | - Revert #34797 See also #35328 It's very likely that the new way will be completely different from this one that is being reverted. That's why I'm reverting rather than fixing it. Commits ------- 9ca8720 Fixed #34713 Move new messages to intl domain when possible 56e79fe Revert "Fixed translations file dumper behavior"
* 4.4: [DI] Fix EnvVar not loaded when Loader requires an env var Fixed #34713 Move new messages to intl domain when possible [FrameworkBundle] Fix small typo in output comment chown and chgrp should also accept int as owner and group Revert "Fixed translations file dumper behavior" Fix RememberMe with null password [Validator] Fix plurals for sr_Latn (Serbian language written in latin script) validation messages Set booted flag to false when test kernel is unset [FrameworkBundle] remove messenger cache if not enabled [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some unneeded code [HttpClient] Fix strict parsing of response status codes fix PHP const mapping keys using the inline notation [SecurityBundle] Drop duplicated code [FrameworkBundle] Make sure one can use fragments.hinclude_default_template Fix that no-cache requires positive validation with the origin, even for fresh responses Improve upgrading instructions for deprecated router options [DI] Suggest typed argument when binding fails with untyped argument
* 5.0: [Filesystem] chown and chgrp should also accept int as owner and group [DI] Fix EnvVar not loaded when Loader requires an env var Fixed #34713 Move new messages to intl domain when possible [FrameworkBundle] Fix small typo in output comment chown and chgrp should also accept int as owner and group Revert "Fixed translations file dumper behavior" Fix RememberMe with null password [Validator] Fix plurals for sr_Latn (Serbian language written in latin script) validation messages Set booted flag to false when test kernel is unset [FrameworkBundle] remove messenger cache if not enabled [PhpUnitBridge][SymfonyTestsListenerTrait] Remove some unneeded code [HttpClient] Fix strict parsing of response status codes fix PHP const mapping keys using the inline notation [SecurityBundle] Drop duplicated code [FrameworkBundle] Make sure one can use fragments.hinclude_default_template Fix that no-cache requires positive validation with the origin, even for fresh responses Improve upgrading instructions for deprecated router options [DI] Suggest typed argument when binding fails with untyped argument
I would like to reopen this issue as I have been experiencing similar issues with the The issue also exists in the latest bugfix release (5.0.7 at the moment of writing). Here's what I'm currently using:
|
Please, open a new issue. |
If I'm using a file named
translations/messages+intl-icu.fr.xlf
for translations, thetranslation:update
command will create atranslations/messages.fr.xlf
file instead of updating the existing one./cc @yceruto
The text was updated successfully, but these errors were encountered: