[DependencyInjection] Possible tiny bug with test #35505
Comments
signor-pedro
added a commit
to signor-pedro/symfony
that referenced
this issue
Jan 29, 2020
Rename testThrowsExceptionWhenAddServiceOnACompiledContainer to testNoExceptionWhenAddServiceOnACompiledContainer.
This was referenced Jan 29, 2020
|
For reference, next step found in #35507 (comment) |
nicolas-grekas
added a commit
that referenced
this issue
Feb 3, 2020
This PR was merged into the 3.4 branch. Discussion ---------- [DependencyInjection] Fix typo in test name Rename testThrowsExceptionWhenAddServiceOnACompiledContainer to testNoExceptionWhenAddServiceOnACompiledContainer. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes (technically) | New feature? | no | Deprecations? | no | Tickets | #35505 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 9cbfad5 [DependencyInjection] #35505 Fix typo in test name
nicolas-grekas
added a commit
that referenced
this issue
Feb 3, 2020
* 3.4: [Phpunit] Fix running skipped tests expecting only deprecations [DependencyInjection] #35505 Fix typo in test name [Yaml][Inline] Fail properly on empty object tag and empty const tag Check non-null type for numeric type Check value isset to avoid PHP notice bug #28179 [DomCrawler] Skip disabled fields processing in Form
chalasr
added a commit
that referenced
this issue
Feb 3, 2020
* 4.4: [Phpunit] Fix running skipped tests expecting only deprecations Fix merge [Config] dont catch instances of Error [HttpClient] fix HttpClientDataCollector when handling canceled responses [DependencyInjection] #35505 Fix typo in test name [Yaml][Inline] Fail properly on empty object tag and empty const tag Check non-null type for numeric type Check value isset to avoid PHP notice bug #28179 [DomCrawler] Skip disabled fields processing in Form
chalasr
added a commit
that referenced
this issue
Feb 3, 2020
* 5.0: [Phpunit] Fix running skipped tests expecting only deprecations Fix merge [Config] dont catch instances of Error [HttpClient] fix HttpClientDataCollector when handling canceled responses [FrameworkBundle] remove mention of the old Controller class [DependencyInjection] #35505 Fix typo in test name [Yaml][Inline] Fail properly on empty object tag and empty const tag Check non-null type for numeric type Check value isset to avoid PHP notice bug #28179 [DomCrawler] Skip disabled fields processing in Form
|
I think this one can be closed isn'it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Symfony version(s) affected: 5.0
Description
There is a test called
testThrowsException...but it does notexpectException.https://github.com/symfony/dependency-injection/blob/0f495ead513e83d01e4363995c1d6984e2a0f9ed/Tests/ContainerBuilderTest.php#L1100
Either the test is misnamed (should be rather
testNoExceptionWhenAddServiceOnACompiledContainer) or it might be a false-positive and the exception check was forgotten (improbable).Possible Solution
Rename the test or add the necessary check.
I assume this is a typo so I renamed the test in my PR.
The text was updated successfully, but these errors were encountered: