Skip to content

[PropertyAccess] BC break due to a modified getter calling logic #37052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1ed opened this issue Jun 1, 2020 · 1 comment
Closed

[PropertyAccess] BC break due to a modified getter calling logic #37052

1ed opened this issue Jun 1, 2020 · 1 comment
Labels
Bug PropertyAccess Status: Needs Review

Comments

@1ed
Copy link
Contributor

1ed commented Jun 1, 2020 •
edited
Loading

Symfony version(s) affected: 5.1.0

Description
I think there is a BC break in the PropertyAccess component due to the changes were introduces in #30704 (I think). The original logic is in https://github.com/symfony/symfony/blob/v5.0.9/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L470-L520. Maybe it's an edge case, but it breaks out app.

How to reproduce
See #37053, the tests green on 5.0, but without the patch failing on. 5.1

Possible Solution
See #37053 for a naive solution.
@1ed 1ed added the Bug label Jun 1, 2020
@1ed 1ed mentioned this issue Jun 1, 2020
Merged
@norkunas
Copy link
Contributor

norkunas commented Jun 2, 2020

We also hit this.

nicolas-grekas added a commit that referenced this issue Jun 7, 2020
@nicolas-grekas
bug #37053 [PropertyAccess] Fix getter call order BC (1ed)
5de548b 
This PR was merged into the 5.1 branch.

Discussion
----------

[PropertyAccess] Fix getter call order BC

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | #37052
| License       | MIT
| Doc PR        | -

Property Accessor breaks BC due to a change in the order of calling the getters, see #37052

Commits
-------

8cf8068 [PropertyAccess] Fix getter call order BC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug PropertyAccess Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@1ed @nicolas-grekas @xabbuh @norkunas @carsonbot