Skip to content

[Form] broken nested configuration #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dinamic opened this issue Apr 5, 2012 · 2 comments
Closed

[Form] broken nested configuration #3792

dinamic opened this issue Apr 5, 2012 · 2 comments

Comments

@dinamic
Copy link

dinamic commented Apr 5, 2012

Line FormFactory.php:242 breaks nested configuration.

Example case - I have a form, which has a subform, which has a component that needs to receive some parameters. In order to do that I make nested configuration.

Unfortunately, using array_replace() instead of array_replace_recursive() makes the whole subarray to be replaced if I specify only one of the settings, while I expected the default options to be used.

I've tried to pull request from my forked copy with a fix for this, but github wants me to sent the request having 14 other commits, which are clearly not mine. Please, someone fix it and push a PR :)

@stof
Copy link
Member

stof commented Apr 5, 2012

@dinamic if you have extra commits in it, it probably means that you are not sending the PR to the right target. If you based your work on the 2.0 branch, take care to send the PR to the 2.0 branch too

@webmozart
Copy link
Contributor

Closed in favor of #4833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants