Skip to content

[Console] Required parameter $maxLength follows optional parameter $verbosity on PHP 8 #39208

Closed
@crynobone

Description

@crynobone

Symfony version(s) affected: symfony/console (5.x-dev 3f7fc42)

Description
Code failing when using SymfonyStyle with TrimmedBufferOutput introduced in #39160 on PHP8 environment.

 1) Orchestra\Testbench\Tests\Databases\MigrateDatabaseTest::it_runs_the_migrations
ErrorException: Required parameter $maxLength follows optional parameter $verbosity

/home/runner/work/testbench-core/testbench-core/vendor/symfony/console/Output/TrimmedBufferOutput.php:27
/home/runner/work/testbench-core/testbench-core/vendor/symfony/console/Style/SymfonyStyle.php:49
/home/runner/work/testbench-core/testbench-core/vendor/laravel/framework/src/Illuminate/Console/OutputStyle.php:29
/home/runner/work/testbench-core/testbench-core/vendor/mockery/mockery/library/Mockery/Container.php:476
/home/runner/work/testbench-core/testbench-core/vendor/mockery/mockery/library/Mockery/Container.php:218
/home/runner/work/testbench-core/testbench-core/vendor/mockery/mockery/library/Mockery.php:117
/home/runner/work/testbench-core/testbench-core/vendor/laravel/framework/src/Illuminate/Testing/PendingCommand.php:269
/home/runner/work/testbench-core/testbench-core/vendor/laravel/framework/src/Illuminate/Testing/PendingCommand.php:204
/home/runner/work/testbench-core/testbench-core/vendor/laravel/framework/src/Illuminate/Testing/PendingCommand.php:390
/home/runner/work/testbench-core/testbench-core/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/InteractsWithConsole.php:66
/home/runner/work/testbench-core/testbench-core/tests/Databases/MigrateDatabaseTest.php:16

See https://github.com/orchestral/testbench-core/runs/1466935770?check_suite_focus=true

How to reproduce
Use SymfonyStyle with output buffering on PHP 8 should trigger this issue.

Possible Solution
It seem $maxLength should have a default value.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions