Skip to content

[Mailer] Can't use >= 3.0 egulias/EmailValidator dep #39656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
michaljusiega opened this issue Dec 29, 2020 · 3 comments
Closed

[Mailer] Can't use >= 3.0 egulias/EmailValidator dep #39656

michaljusiega opened this issue Dec 29, 2020 · 3 comments
Labels
Bug Mailer Mime Status: Reviewed TwigBridge Validator

Comments

@michaljusiega
Copy link
Contributor

Symfony version(s) affected: 4.4 / 5.1 / 5.2

Description
It is not possible to update to newest 3.0 version (https://github.com/egulias/EmailValidator/releases/tag/3.0.0) because symfony/mailer has constraint for using ^2.1.10 version.

How to reproduce
Create project with composer.json

"egulias/email-validator": "^3.0",
"symfony/mailer": "^5.2",

Possible Solution
Modify symfony/mailer composer.json for allow ^2.1.10|^3.0 or >=2.1.10

Additional context
At first look, there is no BC-BREAK changes.

Ready to make PR.
@michaljusiega michaljusiega mentioned this issue Dec 29, 2020
Closed
@derrabus
Copy link
Member

We should allow v2 and v3 to allow users to migrate at their own pace.

Ready to make PR

Yes please. But please note that egulias/email-validator is not only used by Mailer.

@michaljusiega
Copy link
Contributor Author

@derrabus PR is currently opened (#39657).

@derrabus derrabus mentioned this issue Jan 2, 2021
Merged
@derrabus
Copy link
Member

derrabus commented Jan 3, 2021

New PR: #39685

fabpot added a commit that referenced this issue Mar 7, 2021
@fabpot
bug #39685 [Mailer][Mime][TwigBridge][Validator] Allow egulias/email-…
d8cfa3e 
…validator 3.x (derrabus)

This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer][Mime][TwigBridge][Validator] Allow egulias/email-validator 3.x

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39656
| License       | MIT
| Doc PR        | N/A

Commits
-------

3beeadb Allow egulias/email-validator 3.x
@fabpot fabpot closed this as completed Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Mailer Mime Status: Reviewed TwigBridge Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fabpot @derrabus @carsonbot @michaljusiega