Skip to content

[Messenger][MonologBridge] Reset logs between jobs #40451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbond opened this issue Mar 11, 2021 · 4 comments
Closed

[Messenger][MonologBridge] Reset logs between jobs #40451

kbond opened this issue Mar 11, 2021 · 4 comments

Comments

@kbond
Copy link
Member

kbond commented Mar 11, 2021

Description
Long running processes using fingers crossed handler can be problematic. See symfony/symfony-docs#15086 for details.

A possible solution could be resetting them between jobs via the WorkerMessageHandledEvent (similar to doctrine em resets). Perhaps before processing the first job as well.

@greg0ire
Copy link
Contributor

This is how it is done for Swarrot, BTW: https://github.com/swarrot/swarrot/pull/215/files

@kbond
Copy link
Member Author

kbond commented Mar 12, 2021

Could resetting the container be an option here as well? Does resetting the container clear the Doctrine em's (if so, DoctrineClearEntityManagerWorkerSubscriber could be removed)?

@kbond
Copy link
Member Author

kbond commented Apr 18, 2021

I believe #40761 solves?

@fabpot
Copy link
Member

fabpot commented Apr 18, 2021

Closing then.

@fabpot fabpot closed this as completed Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants