Skip to content

[HttpFoundation] Add getString to ParameterBag #41764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shyim opened this issue Jun 21, 2021 · 1 comment
Closed

[HttpFoundation] Add getString to ParameterBag #41764

shyim opened this issue Jun 21, 2021 · 1 comment
Labels
HttpFoundation

Comments

@shyim
Copy link
Contributor

shyim commented Jun 21, 2021

Description
After upgrade to 5.3 I have soo many PhpStan issues like

Parameter #1 $customerId of method Shopware\Administration\Controller\AdministrationController::isEmailValid() expects string, bool|float|int|string|null given.

The ParameterBag has already methods like getBoolean / getInt. But not a getString. This would help to fix those issues really fast.

Example

$email = $request->request->getString('email');
@ro0NL
Copy link
Contributor

ro0NL commented Jun 21, 2021

See #37229

and #40680 (comment)

@shyim shyim closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ro0NL @shyim @carsonbot