Skip to content

[Notifier/SmsMessage] Add setFrom method #45435

Closed
@miedzikd

Description

@miedzikd

Description

We would love to start using Symfony Notifier for sending SMS notifications in our project. We have just one blocker.
In most countries, we use our brand name in the sender name. But due to regulations in the U.S., we have to use a regular number. Due to the volume of messages we send, we have several numbers that we use evenly.

Right now we can define default 'from' when we set DNS (Docs). But there is no posibility to change this default variable.

What do you think about adding setForm method on SmsMessage class? I think this optional step will be really helpful not only for us :)
If you agree I can prepare PR - it looks like not really complicated issue :)

We love what are you doing :)
Greetings from Poland
Daniel

Example

use Symfony\Component\Notifier\Message\SmsMessage;

$sms = new SmsMessage(
  // the phone number to send the SMS message to
  '+1411111111',
  // the message
  'A new login was detected!'
);
$sms->setFrom('+48 123 456 789');

$sentMessage = $texter->send($sms);

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions