semi related #46445

@DaDeather interesting does this also mean that app.request is empty when you do:

return new StreamedResponse(function () use ($twig) {
    $twig->display('template.html.twig');
});

?

@DaDeather interesting does this also mean that app.request is empty when you do:

return new StreamedResponse(function () use ($twig) {
    $twig->display('template.html.twig');
});

?

Yes, exactly.
Since the app.request is calling \Symfony\Component\HttpFoundation\RequestStack::getCurrentRequest it is returning null instead of the request object.

Maybe something like the following in the HttpKernel would be required to fix this issue and not lose compatibility to roadrunner or swoole streamed response:

if ($response instance of StreamedResponse) {
    $callback = $response->getCallback();
    $response->setCallback(function() use ($callback) {
        try {
             $callback();
        } finally {
             $this->requestStack->pop();
        }
    });
} else {
    $this->requestStack->pop();
}

/cc @nicolas-grekas what do you think?

The #46445 would require another fix in the browserkit to convert StreamedResponse into browserkit response correctly.

I was also affected by this in our application. We have a lot of legacy code that we simply wrapped in StreamedResponse-callbacks (similar to what's described in https://symfony.com/doc/current/migration.html). This broke in 6.1 because the RequestStack is empty inside the callback, which means the callback can't access the Session or make Sub-Requests.

I decided to simply re-add a clone of the StreamedResponseListener for the time being:

<?php
declare(strict_types=1);

namespace App\EventSubscriber;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class MyStreamedResponseListener implements EventSubscriberInterface
{

  public function onKernelResponse(ResponseEvent $event)
  {
    if (!$event->isMainRequest()) {
      return;
    }

    $response = $event->getResponse();

    if ($response instanceof StreamedResponse) {
      $response->send();
    }
  }

  public static function getSubscribedEvents(): array
  {
    return [
        KernelEvents::RESPONSE => ['onKernelResponse', -1024],
    ];
  }
}

This seems to work fine for us. I just rolled out the fix today.

Hey, thanks for your report!
There has not been a lot of activity here for a while. Is this bug still relevant? Have you managed to find a workaround?

@carsonbot yes it is still relevant and also present in Symfony 6.2.7.

My workaround above works, but I still consider this a bug in the framework and a BC break in Symfony 6.1.

We are also running into this. We use streamed responses for processes that take a while, where we show a progress bar in the UI. However, we then can't add any flashes anymore. I don't really like the old workaround, since clearly there is a reason Symfony doesn't do that anymore. I hope we can find a decent solution.

still relevant in 6.2.9

@alexander-schranz up to give a PR a try?
Anyone else?

I have opened up a PR for this issue based on @alexander-schranz code.

I think we completely missed this consequence. It'd be fine reverting #45476, and adding also a test case that covers this situation so that we won't forget about the use case again.

I've created a PR to revert #45476 and add a test to it:
#51391