Skip to content

[AmqpMessenger] always return bool from messenger amqp conncetion ack and nack #51397

Closed as not planned
@fvhde

Description

@fvhde

Symfony version(s) affected

5.4

Description

Each times we've an async message consumed, we get

Symfony\Component\Messenger\Bridge\Amqp\Transport\Connection::ack(): Return value must be of type bool, null returned

/vendor/symfony/amqp-messenger/Transport/Connection.php in Symfony\Component\Messenger\Bridge\Amqp\Transport\Connection::ack at line 459

    public function ack(\AMQPEnvelope $message, string $queueName): bool
    {
459 ->        return $this->queue($queueName)->ack($message->getDeliveryTag());
    }

How to reproduce

composer.json

{
    "name": "ayruu/ms-flight",
    "description": "...",
    "type": "project",
    "license": "proprietary",
    "require": {
        "php": "^8.1",
        "ext-ctype": "*",
        "ext-iconv": "*",
        "symfony/asset": "5.4.*",
        "symfony/console": "5.4.*",
        "symfony/dotenv": "5.4.*",
        "symfony/flex": "^1.3.1",
        "symfony/framework-bundle": "5.4.*",
        "symfony/http-client": "5.4.*",
        "symfony/intl": "5.4.*",
        "symfony/monolog-bundle": "^3.3",
        "symfony/options-resolver": "5.4.*",
        "symfony/property-access": "5.4.*",
        "symfony/property-info": "5.4.*",
        "symfony/security-bundle": "5.4.*",
        "symfony/serializer": "5.4.*",
        "symfony/translation": "5.4.*",
        "symfony/twig-bundle": "5.4.*",
        "symfony/validator": "5.4.*",
        "symfony/workflow": "5.4.*",
        "symfony/yaml": "5.4.*",
        "symfony/messenger": "^5.2"
    },
    "require-dev": {},
    "conflict": {
        "symfony/symfony": "*"
    },
    "config": {
        "bin-dir": "bin",
        "preferred-install": {
            "*": "dist"
        },
        "sort-packages": true,
        "allow-plugins": {
            "composer/package-versions-deprecated": true,
            "phpro/grumphp": true,
            "symfony/flex": true
        }
    },
    "extra": {
        "symfony": {
            "allow-contrib": false,
            "require": "5.4.*"
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "src/"
        },
    },
    "autoload-dev": {
        "psr-4": {
            "App\\Tests\\": "tests/"
        }
    },
    "prefer-stable": true,
    "scripts": {}
}

Possible Solution

Seems that there is a fix with the 2 last commits on https://github.com/symfony/amqp-messenger/commits/5.4 but there is no patch containing those.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions