Skip to content

Remove Gitter Notifier / add Matrix Notifier #52862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DAcodedBEAT opened this issue Dec 1, 2023 · 6 comments · Fixed by #57658
Closed

Remove Gitter Notifier / add Matrix Notifier #52862

DAcodedBEAT opened this issue Dec 1, 2023 · 6 comments · Fixed by #57658
Labels
Feature Notifier Status: Needs Review

Comments

@DAcodedBEAT
Copy link
Contributor

DAcodedBEAT commented Dec 1, 2023 •
edited
Loading

Symfony version(s) affected

>=5.3.0

Description

The Gitter API is no longer available, and was slated for removal as far back as January 2023 (https://blog.gitter.im/2023/01/16/gitter-is-going-fully-native-matrix-in-feb-2023/), with removal taking place in February 2023 (https://blog.gitter.im/2023/02/13/gitter-has-fully-migrated-to-matrix/).

What can be done

Since this API is no longer supported, Symfony should:

  1. remove the currently provided (and unusable) Gitter Notifier Component

(and optionally)

  1. create a generalized Matrix Notifier Component so users of Gitter (and any other Matrix chat server) can use The Notifier component from Symfony to send messages to the users.

How to reproduce

Attempt to use the Gitter Notifier component.

Possible Solution

see list item # 2 above

Additional Context

No response
@DAcodedBEAT DAcodedBEAT added the Bug label Dec 1, 2023
@carsonbot
Copy link

Thank you for this suggestion.
There has not been a lot of activity here for a while. Would you still like to see this feature?

@DAcodedBEAT
Copy link
Contributor Author

Thank you for this suggestion. There has not been a lot of activity here for a while. Would you still like to see this feature?

yes. At least for the Symfony codebase, we should remove the Gitter Notifier if the Gitter API is no longer available.

@carsonbot carsonbot removed the Stalled label Jun 5, 2024
@fabpot fabpot mentioned this issue Jul 5, 2024
Merged
@fabpot
Copy link
Member

fabpot commented Jul 5, 2024

See #57658

@fabpot fabpot closed this as completed Jul 5, 2024
fabpot added a commit that referenced this issue Jul 6, 2024
@fabpot
feature #57658 [Notifier] Remove the Gitter bridge (fabpot)
0d77a05 
This PR was merged into the 7.2 branch.

Discussion
----------

[Notifier] Remove the Gitter bridge

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        | Fix #52862 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT

The Gitter API does not exist anymore.

Commits
-------

e0a1a90 [Notifier] Remove the Gitter bridge
@phtmgt
Copy link

phtmgt commented Jan 9, 2025

Any plans to implement matrix?

@xabbuh
Copy link
Member

xabbuh commented Jan 9, 2025

@phtmgt Will #59377 provide what you would need?

@chii0815
Copy link
Contributor

chii0815 commented Jan 9, 2025

@phtmgt Will #59377 provide what you would need?

But to be honest it would only work with Matrix Synapse or other server implementations that also implement the server-client api v3. So older Matrix Synapse server or server that doesn't implement the server-client api v3 won't be covered by this.

I only tested it with a Matrix Synapse Docker Image v1.90.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Notifier] Remove the Gitter bridge fabpot/symfony
6 participants
@fabpot @xabbuh @DAcodedBEAT @carsonbot @phtmgt @chii0815