Skip to content

[HttpFoundation] [Session] SessionInterface is missing "getFlashBag" method: correct? #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonathaningram opened this issue Sep 20, 2012 · 2 comments
Closed

[HttpFoundation] [Session] SessionInterface is missing "getFlashBag" method: correct? #5568

jonathaningram opened this issue Sep 20, 2012 · 2 comments

Comments

@jonathaningram
Copy link
Contributor

I can create a PR for this, but I'm not sure if there was a reason it was left off the interface?

I searched through the issue history for the method name and could not find any reference to the said method's absence.

https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Session/SessionInterface.php#L207 and https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Session/Session.php#L248

And the PR would go to master, correct?
@fabpot
Copy link
Member

fabpot commented Sep 21, 2012

ping @Drak

@ghost
Copy link

ghost commented Sep 21, 2012

A session implementation does not have to have a flashbag. Symfony's session class has one, but it was not intended to be part of the session interface. Adding one would mean that all session implementation must have flashes. The method in the concrete class is just a shortcut for getBag('flashes').

@fabpot fabpot closed this as completed Sep 21, 2012
@jakzal jakzal mentioned this issue Jun 2, 2014
Closed
@jakzal jakzal mentioned this issue Jul 3, 2014
Closed
@jakzal jakzal mentioned this issue Nov 5, 2014
Closed
@linaori linaori mentioned this issue Jan 4, 2017
Closed
@rpkamp rpkamp mentioned this issue Jul 5, 2019
Closed
@jderusse jderusse mentioned this issue Nov 29, 2020
Closed
@jderusse jderusse mentioned this issue Jun 29, 2021
Closed
@wouterj wouterj mentioned this issue Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabpot @jonathaningram