-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Implement backtracking algorithm in ViolationMapper #5656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
alekitto
pushed a commit
to alekitto/symfony
that referenced
this issue
Dec 21, 2015
…or part of the same) property path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#5656 | License | MIT | Doc PR |
alekitto
added a commit
to alekitto/symfony
that referenced
this issue
Dec 22, 2015
…or part of the same) property path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#5656 | License | MIT | Doc PR |
alekitto
added a commit
to alekitto/symfony
that referenced
this issue
Dec 28, 2015
…or part of the same) property path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#5656 | License | MIT | Doc PR |
fabpot
added a commit
that referenced
this issue
Feb 15, 2016
… the same (or part of the same) property path (alekitto) This PR was squashed before being merged into the 2.3 branch (closes #17099). Discussion ---------- [Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5656 | License | MIT | Doc PR | Commits ------- f005c80 [Form] Fixed violation mapping if multiple forms are using the same (or part of the same) property path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following test (for ViolationMapperTest) should be solved:
In order to do so, a backtracking algorithm needs to be implemented that allows to continue ViolationMapper::matchChild(). The relevant current code is:
Here, when a child is found, it is marked for returning. At a later point, if the error could not be mapped, the remaining children should be searched for matches.
See #5578 for reference.
The text was updated successfully, but these errors were encountered: