RequestPayloadValueResolver should catch invalid values of backed enums #58208
Comments
|
Please provide a reproducer for your bug. |
|
I have added a reproducer at https://github.com/stollr/symfony_issue_58208. The Open http://127.0.0.1:8000/?engineType=diesl to see the error. |
|
It seems to be the same issue as mentioned in #52705, right? |
|
As |
|
Let's close this one as a duplicate of #52705 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If a controller argument is attributed with
MapQueryStringand the class contains a property, which is a backed enum, theBackedEnumNormalizeris used to denormalize the value. If a user submits an invalid value for the enum, aValueErroris catched and anSymfony\Component\Serializer\Exception\InvalidArgumentExceptionis rethrown.But this exception is never catched and thus resulting in a 500 internal server error response.
I suggest catching this exception in the
RequestPayloadValueResolverand throw an HttpExceptionwith a 422 or 400 status code (or with the
validationFailedStatusCodedefined in the attribute), because this is a client error.What do you think?
Example
No response
The text was updated successfully, but these errors were encountered: