Request isn't really a service so I probably wouldn't recommend bringing ResetInterface into the mix.

The idea of Request::$currentFormat is probably more feasible, but note the specific nature of the issue is that once a mapping for a format to its MIME types, like in this case the change of 'json' => ['application/json'] to 'json' => ['application/problem+json'], it is the subsequent call to getFormat('application/json') that fails, and in the case of API Platform bug I experienced, this call in worker mode was being made by JsonLoginAuthenticator::supports - something that sits outside API Platform, where it would have no way to inject a $currentFormat (except with a sufficiently high priority kernel listener). I think this might get messy in different applications or bundles interacting with each other.

I wonder if the better solution is to just a provide a wrapper in Request on initializeFormats that products like API Platform can call at the end of each request in their own kernel.terminate listeners, e.g. public reinitializeFormats(): void

Or the same approach but instead of leaving it to applications to take care of resetting this state, Symfony's kernel should reinitialize formats automatically on Request at the end of each main request.

I'm wondering why ApiPlatform overrides the mime type associated with the json format. This seems the root cause of the issue to me

I'm wondering why ApiPlatform overrides the mime type associated with the json format. This seems the root cause of the issue to me

@stof

In a sense, it is, and it's a bug in API Platform for which I've submitted a patch.

But I agree with @soyuka and @dunglas that given Symfony provides a public interface to change these mappings in Request, it's reasonable that Symfony as a framework intended to work with different runtimes should also provide a means to clean up that state between requests in long-running workers.

I'm wondering why ApiPlatform overrides the mime type associated with the json format. This seems the root cause of the issue to me

This is the point of the setFormat method, to be able to change mime types for specific formats. We do this for errors but also for many other json formats (json-ld, hal, openapi, json api). I think that it'd be nice to be able to use setFormat without having issues with workers like swoole or FrankenPHP as it's an annoying bug to track down.

We can solve this either in HttpKernel or in the runtime component. Which one would make most sense?

We can solve this either in HttpKernel or in the runtime component. Which one would make most sense?

In HttpKernel::terminate I'd have thought, or wherever it is services tagged with kernel.reset get called - certainly I think that's the point in the execution flow you'd want this to be cleaned up.

@nicolas-grekas it's better to do it in HttpKernel, otherwise we'll have to patch all runtimes.