Skip to content

[FrameworkBundle] Enable --show-arguments in debug:container by default #59187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vudaltsov opened this issue Dec 11, 2024 · 2 comments · Fixed by #59225
Closed

[FrameworkBundle] Enable --show-arguments in debug:container by default #59187

vudaltsov opened this issue Dec 11, 2024 · 2 comments · Fixed by #59225
Labels
DependencyInjection FrameworkBundle

Comments

@vudaltsov
Copy link
Contributor

Description

I use the debug:container <service> command quite often and always forget to add --show-arguments.

What if I propose to enable --show-arguments by default in Symfony 7.3?

Example

# Before
bin/console debug:container router --show-arguments
# After
bin/console debug:container router
@chalasr
Copy link
Member

chalasr commented Dec 11, 2024

👍 Same here. We will probably need a BC layer for this as some can rely on the the structure of the command output can be redirected. So it means deprecating not setting the option to true explicitly in 7.3, then make it default true in 8.0.

@vudaltsov
Copy link
Contributor Author

👍 Same here.

Thank you! I will work on it soon.

some can rely on the the structure of the command output

Not against doing that, but is it really worth it? https://symfony.com/doc/current/contributing/code/bc.html does not promise that command output remains the same...

So it means deprecating not setting the option to true explicitly in 7.3

Am I right that this should happen only when at least one service id is passed? For instance, debug:container --parameters should not trigger a deprecation?

@Florian-Merle Florian-Merle mentioned this issue Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DependencyInjection FrameworkBundle
Projects
None yet
Milestone
No milestone
4 participants
@xabbuh @vudaltsov @chalasr @carsonbot