-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[VarExporter] Missing fix for lazy objects with hook properties #59843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can you elaborate on the "how to reproduce" part please? Which tests from which PR are you talking about? The tests added in #59761 are present in the |
That's surprising, because I stumbled upon an error that was fixed by that PR, but when you look at the code in 7.3 that But when you look at the current file, it's just not, so I thought this may be the bug I was experiencing, because when I downgraded to 6.4 where that variable is used, it worked. I'm not sure exactly how to reproduce that I'm now using 6.4 and unfortunately I don't have time to isolate it and write tests, it seemed like some merge has overwritten that part of code where array variable |
Closing as it's just that the 6.4 branch has not been merged yet into 7.2 and 7.3. |
Sorry, I checked 7.1, not 7.2. Can you confirm that #59860 fixes your issue? |
Thanks, but for some reason it doesn't, that property is defined as The another one I will report (when I will time to isolate it) is similar (Cannot modify private(set) property) and it's here, maybe it's related, but there is slight chance it may be only doctrine orm related, since it's not ready for hooked properties.
|
This issue description is super misleading: instead of describing the real issue, it describes a guess of a solution. The useful hint came after, in the error message: "Cannot unset private(set) property". And THIS, leads to the correct understanding: support for asymmetric visibility - not hooks. I guess asymmetric visibility needs another round of fixes. |
Yeah, sorry, it seems that problem will be somewhere else and this was just dead code that didn't have effect when corrected as in 6.4, even if the |
See #59884 for the fix |
…as-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [VarExporter] Fix support for asymmetric visibility | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #59843 | License | MIT Commits ------- 7321bbf [VarExporter] Fix support for asymmetric visibility
Symfony version(s) affected
7.2, 7.3
Description
It appears that fix #59761 was not merged all the way to 7.2 and 7.3, there is a code that is missing. The code should work with variable
$hookedProperties
, as in 6.4, but in 7.2 and 7.3 the variable is only created and not used later in code.https://github.com/symfony/symfony/blame/7.3/src/Symfony/Component/VarExporter/Internal/LazyObjectRegistry.php#L69
How to reproduce
Covered in tests of the pull request.
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: