-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] Support region in sendgrid bridge on Symfony 6.4 #59960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Do you mean that the bridge in 6.4 doesn't work at all anymore with something that changed on their side, or do you wish the feature was back ported so you can use it in 6.4? In the second case, I don't think this will happen as features are never back ported. But if the bridge actually can't work anymore, this may be something to discuss. |
I understand your question. To be precise, the Symfony 6.4 bridge still works with SendGrid, but only for US servers. The problem arises when trying to use SendGrid's European servers, because the new SendGrid API requires region specification, a feature that is not present in version 6.4 of the Symfony bridge. In summary: Current operation (6.4): I hope this clarifies the situation. |
So it looks like a back port of the feature and this is unlikely to happen. Friendly ping @xabbuh to confirm? |
But this means that it won't be possible to use Sendgrid's European servers while remaining on Symfony 6.4 (which Sylius imposes on me). |
Did that work before Sendgrid introduced the region specification? |
perhaps you can leverage https://github.com/cweagans/composer-patches i've done that in the past, works "well" |
@xabbuh |
If the bridge stopped working because of changes made by Sendgrid, I think we should think about a way to make it work again. IIRC we already did that in the past for other bridges. |
The PR merged in 7.2 was about adding support for using the host of the EU region to be able to send mails with the EU region of Sendgrid. It is not adding a new parameter. |
I may have poorly expressed my problem. But if we use the new API |
In this case I have to correct my previous comment. I understood that the bridge wasn't no longer working because of changes being done by Sendgrid. But as I understand this now you (or your customer) also opted to use a new feature provided by Sendgrid. In this case I am not convinced that this justifies backporting #58264 to the |
I also don't think we should backport it. If you want to benefit from a new feature of the bridge (being able to use the new European infrastructure of Sendgrid), you need to use the version of the bridge in which this feature was added. It is not a bugfix of the bridge. |
Unfortunately, I'm stuck in Symfony 6.4 with Sylius. |
Description
Hello,
With the new European serveur used in Sendgrid, the Sendgrid mailer doesn't support region param in Symfony 6.4. I found a MR to add this region param on Symfony mailer 7.2.
It is possible to merge this code on Symfony 6.4 to handle Sendgrid region param ?
Thank you very much.
The text was updated successfully, but these errors were encountered: