Skip to content

Option --no-fill on translations:extract don't work on custom domain #60274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CODEheures opened this issue Apr 25, 2025 · 1 comment
Open

Option --no-fill on translations:extract don't work on custom domain #60274

CODEheures opened this issue Apr 25, 2025 · 1 comment
Labels
Bug Status: Needs Review Translation

Comments

@CODEheures
Copy link

CODEheures commented Apr 25, 2025 •
edited
Loading

Symfony version(s) affected

7.2.4

Description

If i want extract translations for my custom domain with --no-fill option, the command don't remove the translation and keep the NO_FILL_PREFIX on the translation.
Example of output:
'Editer mon profil': "\0NoFill\0Editer mon profil"

How to reproduce

php bin/console translation:extract --force --no-fill --format=yaml --domain=mycustomdomain en

Possible Solution

Adapt vendor/symfony/framework-bundle/Command/TranslationUpdateCommand->removeNoFillTranslations to parse targeted domain (or all domains if option domain is not specify).

Additional Context

No response
@CODEheures CODEheures added the Bug label Apr 25, 2025
@gdbonino
Copy link

I encountered the same problem. I don't see the point of just doing it with the messages domain. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Needs Review Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xabbuh @gdbonino @CODEheures @carsonbot