Skip to content

[RFC][Messenger] Only log successfull acks #60368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ro0NL opened this issue May 7, 2025 · 1 comment
Closed

[RFC][Messenger] Only log successfull acks #60368

ro0NL opened this issue May 7, 2025 · 1 comment
Labels
Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed)

Comments

@ro0NL
Copy link
Contributor

ro0NL commented May 7, 2025 •
edited
Loading

Description

Hi,

Given

symfony/src/Symfony/Component/Messenger/Worker.php

Line 228 in ed0a235

$this->logger->info('{class} was handled successfully (acknowledging to transport).', $context);

I'm wondering if we can move the log after the envelope being ack'd, with a special context field (acked: true).

This way we can easily filter for logs, and see the correct number (more trustworthy) of actual acks. Which to me seems more usefull.

Example

No response
@carsonbot carsonbot added Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed) labels May 7, 2025
@ro0NL ro0NL closed this as completed May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Messenger RFC RFC = Request For Comments (proposals about features that you want to be discussed)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ro0NL @carsonbot