Skip to content

[Cache][Messenger] Redis messenger options changes created BC break #61590

@cyberemissary

Description

@cyberemissary

Symfony version(s) affected

7.3

Description

Hi,
Not sure if this was intentional but there is no mention of this in change logs, upgrade, or online documentation.

In 5546196#diff-a722c1aa345575df9562fc76db87e4dc9d1e610f9084a26627b6289655e891d3

The settings were silently changed in src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php:49

-        'sentinel_master' => null, // String, master to look for (optional, default is NULL meaning Sentinel support is disabled)
-        'redis_sentinel' => null, // String, alias for 'sentinel_master'
+        'sentinel' => null, // String, master to look for (optional, default is NULL meaning Sentinel support is disabled)

How to reproduce

Attempt to configure transport with the old setting result in an error: Invalid option(s) "sentinel_master" passed to the Redis Messenger transport.

example:
redis:?host[redis01:26379]&host[redis02:26379]&host[redis03:26379]&sentinel_master=redis-master

changing to new undocumented setting works as expected:
redis:?host[redis01:26379]&host[redis02:26379]&host[redis03:26379]&sentinel=redis-master

Possible Solution

If options are intentionally being removed/renamed follow the standard deprecation practice and also document in change/upgrade logs.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions