Skip to content

Undocumented BC break in 2.3 #8347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stof opened this issue Jun 24, 2013 · 2 comments
Closed

Undocumented BC break in 2.3 #8347

stof opened this issue Jun 24, 2013 · 2 comments
Labels
BC Break Critical DependencyInjection

Comments

@stof
Copy link
Member

stof commented Jun 24, 2013

ec1e7ca broke the BC for $container->set('my_id', null) without documenting it, which breaks Symfony\Bridge\Doctrine\Registry::resetService.

See the inline comment for the exact place breaking things.
@stloyd stloyd mentioned this issue Jul 1, 2013
Closed
@eduardosoliv
Copy link
Contributor

This PR means that the BC will be fixed or will be just documented?

@stof
Copy link
Member Author

stof commented Jul 3, 2013

This is a issue report, not a PR. But the related PR is fixing it

@stof stof mentioned this issue Jul 25, 2013
Closed
@fabpot fabpot closed this as completed Jul 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Critical DependencyInjection
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @stof @eduardosoliv