-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[RFC] Let's fix the Form Component #8888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For multi-step forms I recommend using CraueFormFlowBundle. Clientside validation can be done using Parsley.js. |
I know I saw a bundle for reCAPTCHA and dependent selects... I think it comes down to what should be in the core and what should be left for community to manage as 3-rd party package. |
dependent selects aren't too difficult to implement, especially since #8828 was merged |
For ReCaptcha, there is https://github.com/simplethings/SimpleThingsFormExtraBundle/ for instance (it is not the only one) |
Take a look at https://github.com/thrace-project/form-bundle. |
Yes, I know that "There is a bundle for that!", but that wasn't my point. Let me ask you something: which of the following form fields/validations is more frequently used in real-world web apps?
In my experience, the CAPTCHA field is used like a million times more than the other two combined. Unfortunately, the Form component supports the first two fields/validators but not the last one. Do you remember the sfFormExtra plugin for symfony 1.X? It included a CAPTCHA, dependent |
I'd rather vote for moving birthday/issn out of the core than adding these into. |
IMO this is not a need for Symfony core. This is too tightly coupled with user and business logic. I'm even unsure that Symfony should take care of any javascript (there are too many good js libs and frameworks out there). This work should rather be a useful bundle. And +1 for using my Parsley lib :) |
Hi Javier, I partially do agree with you for multi steps forms and dependent selects. They might be provided as core features as long as they don't rely on Javascript. This is impossible to achieve for double drop down lists without refreshing the page when a value is picked from the first list. I would rather suggest to have a single SymfonyFormExtraBundle in which we could gather all these features as it was done with the symfony 1 plugin. |
I guess that one of the main problems is that the Form Component doesn't have Anyway, I'm closing this issue because there is not enough interest in it :) |
I tried the captcha bundle and it is a collander :) http://phpperu.org/blog/upgrade-in-phpperu before i had thousands of spam, now i have around tenths i am with @hhamon in doing a FormExtra and have that bundle either on sensio :) or on FOS bundle of bundles |
quick search for |
A copy of my reply to the corresponding blog post on symfony.es:
|
Pressed the "close" button by accident. |
I think is better if we break this issue into specific ones rather than being a monolithic discussion |
guys regarding what i think @bschussek and @javiereguiluz said. I believe we need to provide some work contributing to Form component. Is the one that has the highest number of issues ~200. If you guys report problems please send a test case with it, not just dump your stuff. Also let's get to work on the issues, filter by Form component and let's help ourselves with this See the list for Form issues here and help me prioritize them I see a lot of people requesting things but not many people stepping up and sending PRs. With this coming hacking day http://doodle.com/vycrabazihq926yq i hope to see a big large group fixing form issues. 👶 |
Closing because there is no interest in this issue. |
This is not a rant about Bernhard Schussek's work on the Form/Validation components. I do really appreciate that he has spent thousands of hours making Symfony better, and as a community we must be really proud to have such a brilliant guy on our side.
The problem
Two years ago Symfony2 launched with a good but unfinished Form component. Today Symfony2 has a better, but still unfinished, Form component. The foundations of the component are solid but, in my opinion, it lacks the following features needed for real-world applications:
<select>
lists (it doesn't have to be generic, supporting two dependent lists is enough).Just look for example at the Gmail registration form. Although it's a not so complex form, it's not easy to do it with Symfony, because it's multi-step, it uses fancy JavaScript client validation, it includes a CAPTCHA and it has some dependent fields (not
<select>
lists).My proposal
Let Bernhard keep working on the foundations on the component and let's organize a community effort to add the previous features to the Symfony 2.X Form Component.
The text was updated successfully, but these errors were encountered: